Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do a little bit of work to try confirm that the git repo found is actually a julia repo before running Core.Compiler test #836

Merged
merged 4 commits into from
Aug 14, 2024
Merged

do a little bit of work to try confirm that the git repo found is actually a julia repo before running Core.Compiler test #836

merged 4 commits into from
Aug 14, 2024

Conversation

KristofferC
Copy link
Collaborator

Try to fix #834. Will confirm on buildkite.

@KristofferC
do a little bit of work to try confirm that the git repo found is act…
55a5450 
…ually a julia repo before running `Core.Compiler` test
@KristofferC
Copy link
Collaborator Author

KristofferC commented Aug 1, 2024 •
edited
Loading

So while I think it is an improvement, it seems that in buildkite we actually reach a julia repo that comes from somewhere..

https://buildkite.com/julialang/julia-buildkite/builds/1646#01910d9b-e1b1-4e5b-a1af-bf4ffea85858/623-675

readdir((Revise.git_repo(Revise.juliadir))[2]) = [".buildkite", ".buildkite-external-version", ".clang-format", ".clangd", 
".codecov.yml", ".devcontainer", ".git", ".git-blame-ignore-revs", ".gitattributes", ".github", ".gitignore", ".mailmap", 
"CITATION.bib", "CITATION.cff", "CONTRIBUTING.md", "HISTORY.md", "LICENSE.md", "Make.inc", "Makefile", 
"NEWS.md", "README.md", "THIRDPARTY.md", "VERSION", "base", "cli", "contrib", "deps", "doc", "etc", "julia", 
"julia-df1976d500-linux-x86_64.tar.gz", "julia.spdx.json", "pkgimage.mk", "src", "stdlib", "sysimage.mk", "test", "typos.toml", "usr"]

@KristofferC
Copy link
Collaborator Author

KristofferC commented Aug 13, 2024 •
edited
Loading

@timholy, can I just disable this test on CI (when env var CI is set)? It would be good to get JuliaCI/julia-buildkite#372 through but I am running out of steam to try to make Revise realize that it shouldn't run this test in this situation.

@timholy
Copy link
Owner

timholy commented Aug 14, 2024

Is there any way we can make it buildkite-specific? If not, the plan to trigger it on CI seems reasonable.

@KristofferC
Copy link
Collaborator Author

Is there any way we can make it buildkite-specific?

Yes, I did that now

@KristofferC KristofferC merged commit 75a09ea into master Aug 14, 2024
17 checks passed
@timholy timholy deleted the kc/gitrepo branch August 15, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test error when testing Revise on buildkite
2 participants
@KristofferC @timholy